Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2 control] exposed status light interface, allowed for firmware to parse both drivetrain and status light commands #192

Merged
merged 15 commits into from
May 30, 2024

Conversation

davidcalderon03
Copy link
Member

@davidcalderon03 davidcalderon03 commented May 21, 2024

Description

This PR does the following:

  • Fixes the status light interface to send a command to the right port and address
  • Allows for both rover drivetrain and status light commands to both be sent to teensy

Testing Steps (if relevant)

  1. colcon build
  2. . install/setup.bash
  3. ros2 launch urc_bringup bringup.launch.py

Expectation: Should start all hardware interfaces and allow you to drive the drivetrain

Self Checklist

  • I have formatted my code using ament_uncrustify --reformat
  • I have tested that the new behavior works

@yambati03 yambati03 self-requested a review May 26, 2024 00:28
@davidcalderon03 davidcalderon03 changed the title Controller Config Fixes [ros2 control] exposed status light interface, allowed for firmware to parse both drivetrain and status light commands May 26, 2024
@davidcalderon03 davidcalderon03 marked this pull request as ready for review May 26, 2024 03:04
@yambati03 yambati03 self-requested a review May 29, 2024 20:15
@davidcalderon03 davidcalderon03 merged commit 64225a6 into master May 30, 2024
3 of 4 checks passed
@davidcalderon03 davidcalderon03 deleted the fix/control branch May 30, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants